Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to select all regions for a user group #44

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Allow to select all regions for a user group #44

merged 4 commits into from
Aug 22, 2024

Conversation

vladhss
Copy link
Contributor

@vladhss vladhss commented Aug 22, 2024

No description provided.

@vladhss vladhss requested a review from a team as a code owner August 22, 2024 11:07
@sahaqaa
Copy link
Contributor

sahaqaa commented Aug 22, 2024

Checked:

  • data source working ok
  • when i don't specify neither of both "vpn_region_ids" and "all_regions_included" it gives error, as expected
  • when i specify both at the same time "vpn_region_ids" and "all_regions_included" it gives error, as expected

All good.

@sahaqaa
Copy link
Contributor

sahaqaa commented Aug 22, 2024

Acceptance test are failing, but @michaelfmnk will take a look at them in the future. Merging for now.

sahaqaa
sahaqaa approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sahaqaa sahaqaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sahaqaa sahaqaa merged commit 3bc4984 into OpenVPN:main Aug 22, 2024
2 of 4 checks passed
@vladhss vladhss deleted the feature/select-all-regions-user-group branch August 28, 2024 12:54
@sahaqaa sahaqaa mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahaqaa sahaqaa sahaqaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladhss @sahaqaa